I am trying to decide how I should handle errors in my Nodejs application. For example I have a database module which exports an object.database.getPartID = async function getPartID(partNumber){ try{ let partID = await pool.query(Select partID from parts where partNumber = '${partNumber}') return partID[0].partID } catch(err){ console.log(err) } } router.post("/someAction",(req,res)=>{ let partNumber = req.body.partNumber try { let partID = await database.getPartID(partNumber) //Continue code res.send({result1,result2}) } catch(err){ console.log(err) } } The error on the getPartID method will happen if a partNumber is supplied that is not in the database. Should I add return false at the catch error section of the code and do something like this?database.getPartID = async function getPartID(partNumber){ try{ let partID = await pool.query(Select partID from parts where partNumber = '${partNumber}') return partID[0].partID } catch(err){ console.log(err) return false } } router.post("/someAction",(req,res)=>{ let partNumber = req.body.partNumber try { let partID = await database.getPartID(partNumber) if(!partID){ res.send("PART NOT FOUND!") return } //Continue code //Do other stuff res.send({result1,result2}) } catch(err){ console.log(err) } } Is this considered a good practice?
Submitted June 18, 2020 at 03:19PM by sahilgreen
No comments:
Post a Comment