Saturday, 12 January 2019

Feedback on a first Node.js project please?

So, I found a way to post cards to MS Teams using Powershell, but I wanted this simple enough so people within our org don't want to have to deal with proxy traversal, cards templates and such, I wanted to make it easy enough for them to throw a simple card out with a one-liner. So I thought, "well, an internal web service that handled all the tricky proxy stuff and took some simple parameters would do" and came to the conclusion this was a fine time to dip my toes in the Node waters.That was Wednesday PM, by Friday I had it working (most of that was finding the right way to get through the proxy) - but as it's literally the first time I've ever written anything in Node, I was hoping for some feedback on what I did, what's wrong, what's a big no-no, what's right, that sort of thing.Given there's very little to it, I'm hoping I've not left any major security holes for example.Threw it onto Github here: https://github.com/lansalot/MSTeamsProxy. I didn't upload node_modules but they are there in the project and not installed globally.Appreciate any useful feedback. Cheers!

Submitted January 12, 2019 at 07:02PM by andyinv

No comments:

Post a Comment